Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DateConverter is not stateless #3

Open
Raeisifard opened this issue Jul 4, 2021 · 1 comment
Open

DateConverter is not stateless #3

Raeisifard opened this issue Jul 4, 2021 · 1 comment

Comments

@Raeisifard
Copy link

When I run the code retrieved from "Some basic code" section in read.me file there is "1370-12-17" in jalaliDate1 as value instead of "1370-11-28". It seems that "dateConverter" is one time usable and is not stateless. So after each use of "dateConverter.jalaliToGregorian()" I must instantiate it again!

@eloyzone
Copy link
Owner

Yes you are right and see this issue.

Although it is easy to be fixed, I am busy. I hope to make it stateless as soon as possible.

Thank you for mentioning.

@eloyzone eloyzone changed the title miscalculating ... DateConverter is not stateless Jul 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants