Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package still refers to and contains old workflow #112

Open
mdingemanse opened this issue Aug 22, 2024 · 5 comments
Open

Package still refers to and contains old workflow #112

mdingemanse opened this issue Aug 22, 2024 · 5 comments

Comments

@mdingemanse
Copy link
Contributor

The packagedown pages somehow still contain the old workflow: https://elpaco-escience.github.io/talkr/articles/workflow.html

The new one is also there: https://elpaco-escience.github.io/talkr/articles/workflows.html

The new one should replace the old one everywhere

@mdingemanse mdingemanse added the bug Something isn't working label Aug 22, 2024
@bvreede
Copy link
Collaborator

bvreede commented Aug 23, 2024

Good catch! This happens sometimes; the quick fix is to re-run the website build manually. The workflow that does this has a manual trigger:
Screenshot 2024-08-23 at 11 04 13

Pressing the 'run workflow' button and running it on the main branch will recreate the page and deploy it to GitHub Pages. It takes a few minutes to run and deploy, but should fix this problem if it occurs again. I just did this, and it has updated the page — refresh if it doesn't work!

@mdingemanse
Copy link
Contributor Author

mdingemanse commented Aug 23, 2024

Actually it's still the case that readme.md refers to https://elpaco-escience.github.io/talkr/articles/workflow.html (singular) which is the old one that doesn't reflect my work in the user-journeys branch. The right URL to the vignette is https://elpaco-escience.github.io/talkr/articles/workflows.html (plural).

I can correct that (just did in main...112-fix-old-workflow-html) but I still wonder why the old one even still exists.

Root cause is my renaming workflow.Rmd to workflows.Rmd but that change was clearly merged to main (workflow.Rmd (singular) doesn't exist anymore). So, I'm confused. Is there some cache I'm not aware of that keeps the old workflow.html alive?

@mdingemanse mdingemanse reopened this Aug 23, 2024
@bvreede
Copy link
Collaborator

bvreede commented Aug 23, 2024

Very possible. @PabRod do you know this?

I'll check the PR!

@mdingemanse
Copy link
Contributor Author

Ready to be closed as the PR is merged, but leaving open to solve the issue of an old workflow.html hanging around somewhere

@PabRod
Copy link
Contributor

PabRod commented Sep 2, 2024

I'll take a look at this, but let's tag it as low priority for now.

@mdingemanse mdingemanse added low priority and removed bug Something isn't working labels Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants