Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.5.8 release to master #411

Closed
4 tasks done
chris18890 opened this issue Mar 20, 2018 · 18 comments · Fixed by #440
Closed
4 tasks done

v0.5.8 release to master #411

chris18890 opened this issue Mar 20, 2018 · 18 comments · Fixed by #440
Assignees
Milestone

Comments

@chris18890
Copy link
Collaborator

chris18890 commented Mar 20, 2018

@elplatt @ramgarden I've merged the 2 PRs (#407 & #410) into dev & created a tag/release. Are we happy to do a PR into master as per the previous release process -

  • deploy a fresh build & DB of dev & test functionality
  • (blow away if needed)
  • deploy a fresh build & DB of master & test functionality
  • deploy dev build over top of master & test functionality
@chris18890 chris18890 self-assigned this Mar 20, 2018
@elplatt
Copy link
Owner

elplatt commented Mar 20, 2018 via email

@chris18890
Copy link
Collaborator Author

@elplatt can't log into the demo instance to test it as per https://groups.google.com/d/topic/seltzercrm-dev/XnFA3OagQPY/discussion, the credentials may have changed

@chris18890 chris18890 added this to the V0.5.6 milestone Mar 23, 2018
@chris18890
Copy link
Collaborator Author

Also, thoughts on having the registration and profile picture modules enabled by default?

Do we also want to have Amazon payments enabled by default? What about PayPal?

@ramgarden
Copy link
Contributor

ramgarden commented Mar 24, 2018 via email

@chris18890
Copy link
Collaborator Author

chris18890 commented Mar 24, 2018

@ramgarden What do you think of it? Are there any things you'd want changed with it?

@ramgarden
Copy link
Contributor

ramgarden commented Mar 24, 2018 via email

@chris18890
Copy link
Collaborator Author

chris18890 commented Mar 24, 2018

Well partly the PayPal side, partly my lack of ability to get #253 sorted :P

@chris18890
Copy link
Collaborator Author

As part of the testing, I've realised there's a blocking issue on doing a fresh install, created #413 to track it :)

@chris18890 chris18890 changed the title 0.5.5 release to master 0.5.6 release to master Apr 1, 2018
@chris18890
Copy link
Collaborator Author

chris18890 commented Mar 12, 2019

@elplatt only a year late, but do we want to do this release? I believe the reporting function was fixed in c49cd1a by @adamundefinied; also demo install is still not working & needs SSL-ified

@ramgarden
Copy link
Contributor

ramgarden commented Mar 12, 2019 via email

@chris18890
Copy link
Collaborator Author

@ramgarden well at least we know that version of code was reasonable stable ;) we should definitely set up a skype call or soemthing to chat about it when you have time & I'll see if I can walk you though it :) is the code that's there currently what's on your github repo?

@ramgarden
Copy link
Contributor

ramgarden commented Mar 12, 2019 via email

@elplatt
Copy link
Owner

elplatt commented Mar 12, 2019

An new release would be great! How confident is everyone about the new install / upgrade process not breaking? Would anyone be willing to do a systematic test of the features?

I may have some time this summer (May?) to put a little work into tidying up the code and merging in changes from i3 and other contributors.

@chris18890
Copy link
Collaborator Author

chris18890 commented Mar 12, 2019

@elplatt -

I'm reasonably confident of the install/upgrade process working, based on the tests in my first post. I do a basic test of

  • import & create some plans
  • import & create some users (with & without various details present)
  • ensure paypal contacts have been created
  • run billing
  • import payments
  • rerun billing

Haven't done much with the key/metadata/mentor/email list modules

@ramgarden -

I've run this comparison and it seems to mostly be

  • updating mysql_ commands to mysqli_ commands
  • code formatting/layout changes for readability
  • moving the emergency contact details from the contact module to the member module
    • DB changes
    • form & view/table changes

So I'm fairly certain that doing a pull of elplatt:master onto your dev branch & deploying should be ok; the dev branches are a little trickier as there's greater diverengce of the code, and once you do elplatt:master > melbourneMkaerSpace:dev, elplatt:dev > melbounreMakerSpace:dev should be a lot simpler. Your branches for issues 375 & 376 can be pruned, the fixes will be in the new master branch

@chris18890 chris18890 changed the title 0.5.6 release to master v0.5.7 release to master Mar 12, 2019
elplatt added a commit that referenced this issue Mar 18, 2019
v0.5.7 - update copyright year & enable additional modules #411
@chris18890
Copy link
Collaborator Author

chris18890 commented Mar 29, 2019

@elplatt @ramgarden so I've done the following successfully, just need to find out what's going on with billing in #425 now!

  • deploy a fresh build & DB of dev & test functionality
  • (blow away if needed)
  • deploy a fresh build & DB of master & test functionality
  • deploy dev build over top of master & test functionality

By testing fucntionality I mean the following

  • import & create some plans
  • import & create some users (with & without various details present)
  • ensure paypal contacts have been created
  • run billing
  • import payments
  • rerun billing

@chris18890
Copy link
Collaborator Author

chris18890 commented Apr 3, 2019

@elplatt on an aside, while I remember - is it worth getting rid of the 0.4.x-dev branch, as it's fairly stale now!

@chris18890 chris18890 changed the title v0.5.7 release to master v0.5.8 release to master Jan 13, 2020
@chris18890
Copy link
Collaborator Author

PR #440 has been opened for this release

@elplatt @ramgarden can yous review & let me know if it's OK to merge?

@chris18890 chris18890 linked a pull request May 4, 2020 that will close this issue
@ramgarden
Copy link
Contributor

ramgarden commented May 4, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants