Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot redirect with partial URLs #25

Open
eliellis opened this issue Jan 26, 2025 · 0 comments
Open

Cannot redirect with partial URLs #25

eliellis opened this issue Jan 26, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@eliellis
Copy link

eliellis commented Jan 26, 2025

What version of Elysia is running?

1.2.10

What platform is your computer?

Darwin 24.1.0 arm64 arm

What steps can reproduce the bug?

Run the following:

import { Elysia } from "elysia";
import { node } from "@elysiajs/node";

const app = new Elysia({
  adapter: typeof Bun === "undefined" ? node() : undefined,
})
  .get("/home", () => {
    return "Home";
  })
  .onError(({ error }) => {
    console.log("Error", error);
  })
  .onRequest(({ request, redirect }) => {
    if (new URL(request.url).pathname !== "/home") {
      return redirect("/home");
    }
  })
  .listen(3000);

const res = await fetch("http://localhost:3000/redirect-me", {
  redirect: "manual",
});

console.log("status", res.status);

await app.stop(true);

What is the expected behavior?

The above should print status 302. Running the same sample with bun run does print status 302.

What do you see instead?

Error TypeError: Failed to parse URL from /home
    at Response.redirect (node:internal/deps/undici/undici:9100:17)
    at redirect (file:///Users/eli/code/elysia-node-redirect-issue/node_modules/elysia/dist/utils.mjs:1037:50)
    ... 4 lines matching cause stack trace ...
    at HTTPParser.parserOnHeadersComplete (node:_http_common:117:17) {
  [cause]: TypeError: Invalid URL
      at new URL (node:internal/url:818:25)
      at Response.redirect (node:internal/deps/undici/undici:9098:23)
      at redirect (file:///Users/eli/code/elysia-node-redirect-issue/node_modules/elysia/dist/utils.mjs:1037:50)
      at Array.<anonymous> (/Users/eli/code/elysia-node-redirect-issue/tests/redirect-invalid-status-code.ts:15:14)
      at Server.map (eval at composeGeneralHandler (file:///Users/eli/code/elysia-node-redirect-issue/node_modules/elysia/dist/compose.mjs:1330:10), <anonymous>:22:43)
      at Server.emit (node:events:507:28)
      at parserOnIncoming (node:_http_server:1153:12)
      at HTTPParser.parserOnHeadersComplete (node:_http_common:117:17) {
    code: 'ERR_INVALID_URL',
    input: '/home'
  }
}
Waiting for the debugger to disconnect...
node:_http_server:358
    throw new ERR_HTTP_INVALID_STATUS_CODE(originalStatusCode);
          ^

RangeError [ERR_HTTP_INVALID_STATUS_CODE]: Invalid status code: undefined
    at ServerResponse.writeHead (node:_http_server:358:11)
    at Elysia.eval [as handleError] (eval at composeErrorHandler (file:///Users/eli/code/elysia-node-redirect-issue/node_modules/elysia/dist/compose.mjs:1435:10), <anonymous>:24:5)
    at Server.map (eval at composeGeneralHandler (file:///Users/eli/code/elysia-node-redirect-issue/node_modules/elysia/dist/compose.mjs:1330:10), <anonymous>:24:26)
    at Server.emit (node:events:507:28)
    at parserOnIncoming (node:_http_server:1153:12)
    at HTTPParser.parserOnHeadersComplete (node:_http_common:117:17) {
  code: 'ERR_HTTP_INVALID_STATUS_CODE'
}

Node.js v23.6.1

Additional information

Additionally, running the following simply hangs:

import { Elysia } from "elysia";
import { node } from "@elysiajs/node";

const app = new Elysia({
  adapter: typeof Bun === "undefined" ? node() : undefined,
})
  .get("/home", () => {
    return "Home";
  })
  .onError(() => {
    console.log("Error");
  })
  .onRequest(({ request, redirect }) => {
    if (new URL(request.url).pathname !== "/home") {
      return redirect("http://localhost:3000/home");
    }
  })
  .listen(3000);

const res = await fetch("http://localhost:3000/redirect-me", {
  redirect: "manual",
});

console.log("status", res.status);

await app.stop(true);

Running the above using bun run prints status 302.

Have you try removing the node_modules and bun.lockb and try again yet?

yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant