Eager macro-expansion failure in lsp-terraform.el

[condy0919]

Thank you for the bug report

• I am using the latest version of lsp-mode related packages.
• I checked FAQ and Troubleshooting sections
• You may also try reproduce the issue using clean environment using the following command: M-x lsp-start-plain

Bug description

According to lsp-protocol.el, the lsp interface of terraform should be:

(lsp-interface (terraform-ls:ModuleCalls (:v :module_calls) nil))
(lsp-interface (terraform-ls:Module (:name :docs_link :version :source_type :dependent_modules) nil))
(lsp-interface (terraform-ls:Providers (:v :provider_requirements :installed_providers) nil))

But three macro-expansion failures happened.

Module

Eager macro-expansion failure: (error "Unknown key: :docs-link.  Available keys: (:name :docs_link :version :source_type :dependent_modules)")

(lsp-defun construct-tf-module ((&terraform-ls:Module :name :docs-link :version :source-type :dependent-modules))
  "Construct `TF-MODULE' using MODULE."
  (make-tf-module :name name
                  :doc-link docs-link
                  :version version
                  :source-type source-type
                  :dependent-modules dependent-modules))

Providers

Eager macro-expansion failure: (error "Unknown key: :provider-requirements.  Available keys: (:v :provider_requirements :installed_providers)")

(lsp-defun lsp-terraform-ls--providers-to-tf-package ((&terraform-ls:Providers :provider-requirements :installed-providers))

ModuleCalls

Eager macro-expansion failure: (error "Unknown key: :module-calls.  Available keys: (:v :module_calls)")

(lsp-defun lsp-terraform-ls--modules-to-tf-module ((&terraform-ls:ModuleCalls :module-calls))
  "Convert MODULES-TREE-DATA to list of `TF-MODULE'."
  (let* ((modules (-map (lambda (x) (construct-tf-module x)) module-calls)))
    modules))

Steps to reproduce

Nothing

Expected behavior

No failures

Which Language Server did you use?

Nothing

OS

Linux

Error callstack

No response

Anything else?

No response

[yyoncho]

cc @psibi

[psibi]

@condy0919 Thanks for the bug report! I tried using lsp-plain-start with my configuration and I wasn't able to reproduce.

Is there any specific steps that I can follow to reproduce this issue ? Sharing your configuration might help me.

[condy0919]

@condy0919 Thanks for the bug report! I tried using lsp-plain-start with my configuration and I wasn't able to reproduce.

Is there any specific steps that I can follow to reproduce this issue ? Sharing your configuration might help me.

Enabling byte-compile (setq no-byte-compile nil) then open /tmp/a.cpp, there will be a failure message in *Messages* buffer.

https://github.com/emacs-lsp/lsp-mode/blob/master/scripts/lsp-start-plain.el#L37=

[psibi]

@condy0919 Thanks, I checked no-byte-compile and it's already set nil for me. I did what you mentioned and this is the error message I'm getting:

Company backend ’company-clang’ could not be initialized:
Company found no clang executable
Wrote /tmp/a.cpp

[condy0919]

@condy0919 Thanks, I checked no-byte-compile and it's already set nil for me. I did what you mentioned and this is the error message I'm getting:

Company backend ’company-clang’ could not be initialized:
Company found no clang executable
Wrote /tmp/a.cpp

Install clang or open an elisp file since lsp is in prog-mode-hook.

[psibi]

Install clang or open an elisp file since lsp is in prog-mode-hook.

Sure, I installed clangd and nothing happened. This is what I saw in my messages buffer:

Wrote /tmp/foo.cpp

I also opened an elisp file and I can't observe anything. I think it would be helpful if you can share your lsp-mode configuration that you are using.

[yyoncho]

@condy0919 are you reproducing the issue with M-x lsp-start-plain?

[condy0919]

@condy0919 are you reproducing the issue with M-x lsp-start-plain?

Yes, except for the nil no-byte-compile variable.

[condy0919]

I will then provide a minimal recipe init.el

[condy0919]

Sorry to disturb, I'm unable to reproduce after deleting all packages and reinstalling them again. :'(

The reason I guess is the *.elc files is generated by Emacs master at commit1, but later they're run on Emacs 29 at commint2.

[ZWindL]

Met the same issue today.
Solution:

1. cd into your lsp-mode package dir
2. remove all .elc file
3. reboot emacs

[mattsawyer77]

I hit this issue today as well. I'm using emacs 29, and commit 0dfe214 of lsp-mode.

The other workarounds posted above didn't seem to work for me, but I don't use terraform these days, so I just removed the client from the list:

(delete 'lsp-terraform lsp-client-packages)

Now all my lsp clients (excluding terraform, of course) seem to work normally.

Another user has forked lsp-mode to add this commit for a seemingly more correct fix: SteVwonder@db55e4f

Perhaps this issue should be reopened?