Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support crystalline for Crystal #4003

Open
restitux opened this issue Mar 26, 2023 · 4 comments
Open

Support crystalline for Crystal #4003

restitux opened this issue Mar 26, 2023 · 4 comments

Comments

@restitux
Copy link

It seems crystalline has replaced scry. The scry repo README now links to crystalline (see https://github.com/elbywan/crystalline).

It did some basic testing by renaming the crystalline binary to scry. Most basic features I tried to use seemed to work correctly.
@yyoncho
Copy link
Member

yyoncho commented Mar 26, 2023

willing to provide a PR?

@restitux
Copy link
Author

Sure, would you suggest dropping support for scry or supporting both?

restitux added a commit to restitux/lsp-mode that referenced this issue Mar 27, 2023
@restitux
Use crystalline instead of scry for Crystal (emacs-lsp#4003)
a584501
@restitux
Copy link
Author

PR assuming we want to drop scry: #4007

@xendk
Copy link
Contributor

xendk commented May 11, 2023

I'll second this.

The current workaround is (setq lsp-clients-crystal-executable '("crystalline" "--stdio")), which works, but would be nice if it just worked out of the box.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@xendk @yyoncho @restitux