Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of string-lines (#4217) #4219

Merged
merged 2 commits into from
Nov 7, 2023
Merged

Remove use of string-lines (#4217) #4219

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c7eb3e0
Remove use of `string-lines` (#4217)
mope-life Nov 6, 2023
7507732
Use `s-lines` to split lines
mope-life Nov 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions lsp-completion.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,8 +355,13 @@ The MARKERS and PREFIX value will be attached to each candidate."
;; `lsp-completion-start-point' above might be from cached/previous completion and
;; pointing to a very distant point, which results in `prefix' being way too long.
;; So let's consider only the first line.
(prefix (car (string-lines prefix)))
(prefix-len (length prefix))
(prefix-len (let ((idx 0)
mope-life marked this conversation as resolved.
Show resolved Hide resolved
(len (length prefix)))
(while (and (< idx len)
(not (= ?\n (elt prefix idx))))
(setq idx (1+ idx)))
idx))
(prefix (substring prefix 0 prefix-len))
(prefix-pos 0)
(label (downcase candidate))
(label-len (length label))
Expand Down
Loading