Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit Testing #2

Open
ejmr opened this issue Aug 29, 2017 · 0 comments
Open

Unit Testing #2

ejmr opened this issue Aug 29, 2017 · 0 comments
Assignees

Comments

@ejmr
Copy link
Contributor

ejmr commented Aug 29, 2017

@zonuexe php-runtime.el is a useful Emacs Lisp project that I feel like I can work on in my spare time given my current health situation. Like all good projects it needs a good suite of unit tests. In order to learn more about the code I am currently working on a test suite using ERT, and hopefully I will soon have a branch of patches to submit. I just wanted to let you know that is a part of the project I am working on.

ejmr pushed a commit that referenced this issue Sep 23, 2018
I said that I would do this a looooong time ago, but am only now
getting around to it (as a result of feeling envigorated to write
code lately).  This patch implements some basic unit tests for our
`php-runtime` library, and in particular the `php-runtime-expr`
part of the API.

The unit test code provides a `run-simple-php` function to help with
testing, allowing us to hand some short code to the PHP executable
for execution.  However, the `php-runtime` library provides this exact
functionality---obviously it must.  Therefore in the future we should
remove our utility from the unit test code and instead rely on the
relevant code from the `php-runtime` library itself.  The only reason
I did not use it in this first draft is because I wanted to re-examine
the code to see if I can simplify it in any meaningful and useful way.

Finally, this file of unit tests is incomplete and we will be adding
more tests in the future, particularly for such things as reading
standard-input into PHP code we wish to run.

GitHub-Issue: #2
Signed-off-by: Eric James Michael Ritz <[email protected]>
@ejmr ejmr self-assigned this Sep 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant