-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is the alpha release usable/testable? #113
Comments
Hi @anthonybocci ! I've been using phpactor for many monthes now and it has definitely been a game changer for my daily php development workflow (no more random completion candidates, common refactorings with a few keystrokes). There has been work to improve the usability, but it's been on develop branch for a long time and we have just recently merged it into master. So I would say we are quite close to a beta quality release that should be usable without too much hassle. And in that regards, it's good to have feedback like yours :-) That said, let's look at your error. I would guess it comes from the following
(that's my guess as you get the error without running anything related to phpactor explicitely). I'd suggest starting by commenting that part and then try to get phpactor working. Then, have you run the You could look at my configuration here if you want to try by using the source (not recommended, but worth trying as a last resort). |
Hi @kermorgant, Thank your for your answer! By removing the lines in my Yes I ran
I'm really glad to learn the project is near of a beta relase! :) I'd be glad to contribute to the project, at least as a user/tester. |
Hi, Thanks, indeed, some feedback would be very welcome :-) (I'm not using melpa myself as I'm working on sources, so I'm crossing my fingers that it just works as it should) I guess the first useful thing you would like to get working is the completion, but before that, you could execute if that does not work, could you look at the value of |
Since I'm using the included package manager I'll see if everything works as it should :). I typed I checked the value of |
hmm, I did not expect that (phpactor-executable being But phpactor-executable being |
That seems strange. I'll list all steps I do and explain the state.
As you can see, with a fresh Emacs instance the value seems to be
I absolutely don't know Lisp. I guess the variable is set as
The plugin is no longer installed so I understand why it no longer work. The problem would be with the expression that defines the variable, right? |
I was assuming phpactor would be reinstalled during restart but that did
not happen. Could you please reinstall ?
Yes, I suspect defvar has something to do with the issue but I'm making
assumptions again :-) I've learnt a bit about elisp while working on this
package but it's limited...
…On Sat, 13 Apr 2019, 21.41 Anthony Bocci, ***@***.***> wrote:
That seems strange. I'll list all steps I do and explain the state.
1. Emacs is closed, I just open my first Terminal on my machine.
2. C-h v and phpactor-executable, here is the output.
phpactor-executable is a variable defined in ‘phpactor-autoloads.el’.
Its value is nil
Automatically becomes buffer-local when set.
This variable is safe as a file local variable if its value
satisfies the predicate ‘(lambda (v) (if (consp v) (and (eq (quote root) (car v)) (stringp (cdr v))) (or (null v) (stringp v))))’.
Documentation:
Path to ‘phpactor’ executable file.
As you can see, with a fresh Emacs instance the value seems to be nil. In
the file ~/.emacs.d/elpa/phpactor-20190403.216/phpactor-autoloads.php I
can see the following:
(defvar phpactor-executable nil "\
Path to `phpactor' executable file.")
(make-variable-buffer-local 'phpactor-executable)
(put 'phpactor-executable 'safe-local-variable #'(lambda (v) (if (consp v) (and (eq 'root (car v)) (stringp (cdr v))) (or (null v) (stringp v)))))
I absolutely don't know Lisp. I guess the variable is set as nill to
declare it first, and then we try to set it.
1. I just deleted the directory ~/.emacs.d/elpa/phpactor-20190403.216/,
closed and restarted Emacs.
2. C-h v and phpactor-executable. I got [No match]. The variable is no
longer defined.
3. M-x and phpactor-status. I got [No match].
The plugin is no longer installed so I understand why it no longer work.
The problem would be with the expression that defines the variable, right?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#113 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AKEoLE0asacsv1vXMuGIKbAV966g32quks5vgiTNgaJpZM4cr-KO>
.
|
It wasn't reinstalled indeed, I didn't expect it to be reinstalled. I tried to install manually the package (let's be crazy) so I cloned your repository to try to hack the part of code that doesn't work, ran The variable If I can help in some way, I'm open to suggestions. |
Oh damned, This is something I've changed in a branch I'm using currently, but that's another story,,, So in fact, it does not look that bad. You might want to try something like By the way, if you want to hack the code, you would still be better running And no, this package does not introduce any keybindings. It's up to every user to define his own. |
Haha ok so the installation was right :) I tried I'll have a look to Lisp and I'll see then if I can play a bit with it. Thank you for your help! EDIT: As a note for myself here is a simple solution to set keybindings. |
Great ! I think you have a point about keybindings, but at the same time, it's a bit tricky to come up with something correct. But in order to be helpful on that side, I think the README could include configuration for some keybindings that the user is free to add, adapt or ignore. Then, for your error : looks like an issue worth exploring at a later stage (by looking at Phpactor Output buffer for example, or by using phpactor's replay function). But right now, I believe you want to use |
I am an Emacs beginner, I try to use phpactor.el to improve my PHP experience.
I installed phpactor by following the standalone way and it seems to be working. When I use it in my directory it works.
I've installed phpactor.el by using
package-install
in Emacs.When I use Emacs to type code, automatically in the mini buffer I see an error.
Here is a code to reproduce it. My point is after the arrow (where I put a pipe) when I the an error.
The error I get:
Phpactor: Unknown item "", known items: "", "", ""
Testing the Phpactor installation:
My
.emacs
about phpactor.el.Since phpactor is under development and phpactor.el is in alpha version, is it usable/testable? Is the error from me/my install, or the plugin isn't usable?
As a side note I'll add that I'm already using phpactor in Vim (in Vim it's not using the standalone install I think though).
The text was updated successfully, but these errors were encountered: