New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validating Host #1

Open

boogie opened this issue Mar 5, 2015 · 0 comments

Labels

bug

Contributor

boogie commented Mar 5, 2015

Validating Host:Port should be checked. Possible problems are:

validateHost calls getServerName(), but serverVars['SERVER_NAME'] will not contain port number - if the server not running on port 80 or 443, it might fail
we should allow the client to add port number, even if its port 80 or 443, and don't fail
isDefaultPort should check if the request was secure or not, and report defaultness accordingly

boogie added the bug label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment