Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update esp32 example for non esp32c3 targets #201

Merged
merged 4 commits into from
Dec 18, 2024

Conversation

bytedream
Copy link
Contributor

@bytedream bytedream commented Dec 17, 2024

This PR changes several things in the the esp32 example:

  • Set espflash flash --monitor to be the runner for all esp related targets
  • Add targets as comments for different chips in config file
  • Add esp32 feature for normal ESP32 chip
  • Add cargo alias to run example on every supported esp32 chip
  • Decrease embassy-executor task arena size to task-arena-size-32768, any higher value will cause an compile error on ESP32
  • Remove esp32s2 feature, this chip doesn't support Bluetooth at all
  • Remove hardcoded esp32c3 feature in esp-backtrace dependency

@jamessizeland
Copy link
Collaborator

might be worth adding some alias lines in .cargo/config.toml, we tend to do this for multi-chip projects, i.e.

[alias]
esp32c3 = "run --release --features=esp32c3 --target=riscv32imc-unknown-none-elf"
esp32c6 = "run --release --no-default-features --features=esp32c6 --target=riscv32imac-unknown-none-elf"

@bytedream
Copy link
Contributor Author

Thanks for the suggestions I'll add it. I didn't knew that an cargo alias could be specified in the config, that's neat

@bytedream bytedream force-pushed the esp32-example-improvements branch from 258481d to a220de6 Compare December 17, 2024 23:28
Copy link
Member

@lulf lulf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thanks!

@lulf
Copy link
Member

lulf commented Dec 18, 2024

/test

@lulf lulf merged commit aaf2d02 into embassy-rs:main Dec 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants