Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Can't render GregTechCEu lamp blocks in inventory when Connected Textures Mod is present #112

Open
MCTian-mi opened this issue Jul 17, 2024 · 2 comments

Comments

@MCTian-mi
Copy link

When CTM, GregTechCEu, VintageFix are all present, some lamps doesn't render in inv:
{A2C0A8F5-6CA0-4011-8B48-2286A0D0851C}

With either CTM or VintagFix absent, lamp blocks renders normally in inv:
{FA85CE25-DD21-4fa4-86D8-5A05A54A23D2}

@embeddedt
Copy link
Owner

I noticed your PR, so I tried tweaking ViF to load AbstractCTMBakedModel less eagerly (to avoid aggressively reading BlockRenderLayer values) but that didn't help.

My suspicion is that this logic in GTCEu isn't effective with ViF because the CTM model wrapping will end up running in the middle of their logic instead of after, as a side effect of ViF having to reimplement the wrapping for dynamic loading.

@MCTian-mi
Copy link
Author

I noticed your PR, so I tried tweaking ViF to load AbstractCTMBakedModel less eagerly (to avoid aggressively reading BlockRenderLayer values) but that didn't help.

My suspicion is that this logic in GTCEu isn't effective with ViF because the CTM model wrapping will end up running in the middle of their logic instead of after, as a side effect of ViF having to reimplement the wrapping for dynamic loading.

I checked that PR again and runs clean before launching, and it seems not to fix the issue here
tbh it seems really weird
I'll take your advice and see if I can fix this in that way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants