Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debug.log ERROR: [VintageFix]: Error accessing resource pack on classpath #117

Open
Krutoy242 opened this issue Jul 30, 2024 · 2 comments
Open

Comments

@Krutoy242
Copy link

Krutoy242 commented Jul 30, 2024

I have at least 5 errors related to VintageFix after updating to new version 0.5.1.
All of them are similar, but one related to some characters in file name.

[Client thread/ERROR] [VintageFix]: Error accessing resource pack on classpath (with URI jar:file:/E:/mc/packs/E2EE-Java22/libraries/cleanroom-0.2.2-alpha%20build.13.run.651-universal.jar)
java.nio.file.NoSuchFileException: E:\mc\packs\E2EE-Java22\libraries\cleanroom-0.2.2-alpha build.13.run.651-universal.jar
	at jdk.nio.zipfs.ZipFileSystem.<init>(Unknown Source) ~[jdk.zipfs:?]
	at jdk.nio.zipfs.ZipFileSystemProvider.getZipFileSystem(Unknown Source) ~[jdk.zipfs:?]
[Client thread/ERROR] [VintageFix]: Error accessing resource pack on classpath (with URI jar:file:/E:/mc/packs/E2EE-Java22/.minecraft/mods/[___MixinCompat-1.1-1.12.2___].jar)
java.lang.IllegalArgumentException: Illegal character in path at index 46: file:/E:/mc/packs/E2EE-Java22/.minecraft/mods/[___MixinCompat-1.1-1.12.2___].jar
	at jdk.nio.zipfs.ZipFileSystemProvider.uriToPath(Unknown Source) ~[jdk.zipfs:?]
	at jdk.nio.zipfs.ZipFileSystemProvider.getFileSystem(Unknown Source) ~[jdk.zipfs:?]

Does this means some VintageFix functionality not working? How I could fix that?

Full log

@nephatrine
Copy link

For the first error, it looks like there is a symbol like maybe a + in the name of that cleanroom jarfile that vintagefix is choking on or not properly escaping. I see something similar with OpenComputers, for instance. Where the original filename includes the + symbol which vintagefix is interpreting as %20 or for some reason and then obviously cannot find the file.

[10:17:14] [Client thread/ERROR] [VintageFix]: Error accessing resource pack on classpath (with URI jar:file:/C:/Users/Nephatrine/AppData/Roaming/PrismLauncher/instances/NephPack2/.minecraft/mods/OpenComputers-MC1.12.2-1.8.6%20cd8851e.jar)
java.nio.file.FileSystemNotFoundException: C:\Users\Nephatrine\AppData\Roaming\PrismLauncher\instances\NephPack2\.minecraft\mods\OpenComputers-MC1.12.2-1.8.6 cd8851e.jar

Normally I'd just suggest renaming the file to silence the warning - you can just replace the + or whatever with a more normal character. Since in your case that is a file in the libraries folder though not a normal mod, I'm not sure if that would mess with anything. I don't think the dynamic resource loader would be able to do anything with that cleanroom jar anyways so I wouldn't expect any issues in your case.


For the second error you posted, VintageFix doesn't like filenames with square brackets [] in them. Instead of eating them like + symbols though, it gives that invalid character error. Again, it's probably just a case of not properly escaping the filenames when passing them around to the java apis. I get the same issue with other mods like that them like HighDPI-Fix, for instance.

[10:17:14] [Client thread/ERROR] [VintageFix]: Error accessing resource pack on classpath (with URI jar:file:/C:/Users/Nephatrine/AppData/Roaming/PrismLauncher/instances/NephPack2/.minecraft/mods/[1.6.1-1.12.2]HighDPI-Fix-1.4.5.jar)
java.lang.IllegalArgumentException: Illegal character in path at index 92: file:/C:/Users/Nephatrine/AppData/Roaming/PrismLauncher/instances/NephPack2/.minecraft/mods/[1.6.1-1.12.2]HighDPI-Fix-1.4.5.jar

I don't think MixinCompat or HighDPI-Fix include any actual resources for the dynamic resources mixin anyways, but it could be an actual issue maybe if other mods with textures and models and whatnot were named like that. In that circumstance, I'd again suggest just changing those symbols to something more normal.

@Krutoy242
Copy link
Author

@nephatrine How I can rename mod files if I'm distributing my modpack with CurseForge? Mods are downloaded from CF as is and launchers doesn't renaming files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants