Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed apply mixin to ObfuscationReflectionHelper with MixinTargetAlreadyLoadedException #88

Open
SettingDust opened this issue Feb 20, 2024 · 3 comments

Comments

@SettingDust
Copy link

SettingDust commented Feb 20, 2024

I'm mixin into ObfuscationReflectionHelper in my mod. But VintageFix breaking that with MixinTargetAlreadyLoadedException

@SettingDust SettingDust changed the title Failed apply mixin to ObfuscationReflectionHelper with VintageFix Failed apply mixin to ObfuscationReflectionHelper with MixinTargetAlreadyLoadedException Feb 20, 2024
@SettingDust
Copy link
Author

SettingDust commented Aug 10, 2024

ObfuscationReflectionHelper.findField(LaunchClassLoader.class, "packageManifests").set(cl, new ConcurrentHashMap() {
@Override
public Object put(Object key, Object value) {
return null;
}
});
Field resourceCacheField = ObfuscationReflectionHelper.findField(LaunchClassLoader.class, "resourceCache");

The fields on the CL won't be obfed. It's launch wrapper instead of the game itself.

And also
https://github.com/embeddedt/VintageFix/blob/main/src/main/java/org/embeddedt/vintagefix/transformercache/TransformerCache.java#L117

@embeddedt
Copy link
Owner

Does 803605a help?

@SettingDust
Copy link
Author

It does

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants