From abf2e7062c9cf3f2c56a970e6e1556a8e5e0a4f3 Mon Sep 17 00:00:00 2001 From: Chris Manson Date: Thu, 9 Nov 2023 21:56:19 +0000 Subject: [PATCH 1/4] drop support for node < 16 --- .github/workflows/{CI.yml => ci.yml} | 31 +++++++++++++++++++++++----- package.json | 4 ++-- 2 files changed, 28 insertions(+), 7 deletions(-) rename .github/workflows/{CI.yml => ci.yml} (83%) diff --git a/.github/workflows/CI.yml b/.github/workflows/ci.yml similarity index 83% rename from .github/workflows/CI.yml rename to .github/workflows/ci.yml index 8b571b46..a2c500f1 100644 --- a/.github/workflows/CI.yml +++ b/.github/workflows/ci.yml @@ -26,12 +26,17 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - node-version: ["12"] + node-version: + - 16 + - 18 + - 20 steps: - uses: actions/checkout@v2 + - uses: actions/setup-node@v4 with: node-version: ${{ matrix.node-version }} + cache: yarn - run: yarn install --frozen-lockfile --non-interactive - run: yarn test @@ -41,12 +46,17 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - node-version: ["12"] + node-version: + - 16 + - 18 + - 20 steps: - uses: actions/checkout@v2 + - uses: actions/setup-node@v4 with: node-version: ${{ matrix.node-version }} + cache: yarn - run: yarn install --frozen-lockfile --non-interactive - run: PREFER_NATIVE=true yarn test @@ -56,12 +66,17 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - node-version: ["12"] + node-version: + - 16 + - 18 + - 20 steps: - uses: actions/checkout@v2 + - uses: actions/setup-node@v4 with: node-version: ${{ matrix.node-version }} + cache: yarn - run: yarn install --frozen-lockfile --non-interactive - run: NATIVE_PROMISE=true yarn test @@ -71,12 +86,17 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - node-version: ["12"] + node-version: + - 16 + - 18 + - 20 steps: - uses: actions/checkout@v2 + - uses: actions/setup-node@v4 with: node-version: ${{ matrix.node-version }} + cache: yarn - run: yarn install --frozen-lockfile --non-interactive - run: yarn run test:node @@ -105,8 +125,9 @@ jobs: allow-failure: true steps: - uses: actions/checkout@v2 + - uses: actions/setup-node@v4 with: - node-version: 12.x + node-version: 16 - name: install dependencies run: yarn install - name: test diff --git a/package.json b/package.json index 28342482..9ae7e08a 100644 --- a/package.json +++ b/package.json @@ -88,7 +88,7 @@ "typescript": "^4.1.3" }, "engines": { - "node": ">= 10" + "node": "16.x || 18.x || >=20.x " }, "publishConfig": { "registry": "https://registry.npmjs.org/" @@ -102,7 +102,7 @@ ] }, "volta": { - "node": "10.24.1", + "node": "16.20.2", "yarn": "1.22.10" } } From 5aba723f74940a555da41f4c11a5445d107edc89 Mon Sep 17 00:00:00 2001 From: Chris Manson Date: Thu, 9 Nov 2023 21:59:57 +0000 Subject: [PATCH 2/4] use a specific node version for the lint step --- .github/workflows/ci.yml | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index a2c500f1..76560aba 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -11,12 +11,20 @@ on: tags: - "*" +concurrency: + group: ci-${{ github.head_ref || github.ref }} + cancel-in-progress: true + jobs: lint: name: "Linting" runs-on: ubuntu-latest steps: - uses: actions/checkout@v2 + - uses: actions/setup-node@v4 + with: + node-version: 16 + cache: yarn - run: yarn install --frozen-lockfile --non-interactive - run: yarn lint:js From 38d85a78afb48c3318ca9aacde2c2b53dcbdb9d3 Mon Sep 17 00:00:00 2001 From: Chris Manson Date: Thu, 9 Nov 2023 22:01:37 +0000 Subject: [PATCH 3/4] add fail-fast: false --- .github/workflows/ci.yml | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 76560aba..69558a2d 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -33,6 +33,7 @@ jobs: name: "Tests: ubuntu (node@${{ matrix.node-version }})" runs-on: ubuntu-latest strategy: + fail-fast: false matrix: node-version: - 16 @@ -53,6 +54,7 @@ jobs: name: "PREFER_NATIVE=true Tests: ubuntu (node@${{ matrix.node-version }})" runs-on: ubuntu-latest strategy: + fail-fast: false matrix: node-version: - 16 @@ -73,6 +75,7 @@ jobs: name: "NATIVE_PROMISE=true Tests: ubuntu (node@${{ matrix.node-version }})" runs-on: ubuntu-latest strategy: + fail-fast: false matrix: node-version: - 16 @@ -93,6 +96,7 @@ jobs: name: "Node Tests: ubuntu (node@${{ matrix.node-version }})" runs-on: ubuntu-latest strategy: + fail-fast: false matrix: node-version: - 16 @@ -116,7 +120,7 @@ jobs: needs: ember-tests strategy: - fail-fast: true + fail-fast: false matrix: ember-try-scenario: - ember-lts-3.4 From 0330bc669787801ef6c23e27b2468b660160fa05 Mon Sep 17 00:00:00 2001 From: Chris Manson Date: Thu, 9 Nov 2023 22:03:25 +0000 Subject: [PATCH 4/4] bump workerpool in yarn lock --- yarn.lock | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/yarn.lock b/yarn.lock index d068bfca..9496cd8e 100644 --- a/yarn.lock +++ b/yarn.lock @@ -13209,9 +13209,9 @@ workerpool@6.1.0: integrity sha512-toV7q9rWNYha963Pl/qyeZ6wG+3nnsyvolaNUS8+R5Wtw6qJPTxIlOP1ZSvcGhEJw+l3HMMmtiNo9Gl61G4GVg== workerpool@^2.3.0: - version "2.3.3" - resolved "https://registry.yarnpkg.com/workerpool/-/workerpool-2.3.3.tgz#49a70089bd55e890d68cc836a19419451d7c81d7" - integrity sha512-L1ovlYHp6UObYqElXXpbd214GgbEKDED0d3sj7pRdFXjNkb2+un/AUcCkceHizO0IVI6SOGGncrcjozruCkRgA== + version "2.3.4" + resolved "https://registry.yarnpkg.com/workerpool/-/workerpool-2.3.4.tgz#661335ded59a08c01ca009e30cc96929a7b4b0aa" + integrity sha512-c2EWrgB9IKHi1jbf4LG9sxKgHYOY+Ej5li6siEGtFecCXWG7eQOqATPEJ0rg1KFETXROEkErc1t5XiNrLG666Q== dependencies: object-assign "4.1.1"