You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We probably should add comment block so IDEs could give hints of expected parameters OR provide TypeScript interface file. I think proper JSDoc for starters would be nice.
This helper does have some internal logic comments in it, we should probably remove it or separate it still for testing specifically this addon vs public helper.
The Array.pop() workaround for consumers is not needed, it's only applicable for tests in this repository.
We probably should add comment block so IDEs could give hints of expected parameters OR provide TypeScript interface file. I think proper JSDoc for starters would be nice.
This helper does have some internal logic comments in it, we should probably remove it or separate it still for testing specifically this addon vs public helper.
The
Array.pop()
workaround for consumers is not needed, it's only applicable for tests in this repository.Originally posted by @raido in #209 (comment)
The text was updated successfully, but these errors were encountered: