New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

undefined value in shoebox throws error #137

Open

kellyselden opened this issue May 16, 2017 · 0 comments

Labels

Member

kellyselden commented May 16, 2017

If you accidentally provide an undefined as a shoebox value, you get the stack trace:

 TypeError: Cannot read property 'replace' of undefined
    at escapeJSONString (/xxx/node_modules/fastboot/src/ember-app.js:478:16)
    at createShoebox (/xxx/node_modules/fastboot/src/ember-app.js:453:17)
    at visitRoute.then.then (/xxx/node_modules/fastboot/src/ember-app.js:316:11)

It would be easy to handle undefined and ignore them.

The text was updated successfully, but these errors were encountered:

kellyselden mentioned this issue

handle undefined in shoebox #138

Open

xg-wang added the enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment