Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Application and ApplicationInstance creation into VM sandbox #244

Open
rwjblue opened this issue Oct 31, 2019 · 0 comments
Open

Move Application and ApplicationInstance creation into VM sandbox #244

rwjblue opened this issue Oct 31, 2019 · 0 comments
Assignees
Milestone

Comments

@rwjblue
Copy link
Member

rwjblue commented Oct 31, 2019

Currently, we do a few things in the node process (instead of within the sandbox context):

  • Require the application factory (require('~fastboot/app-factory'))
  • Create the application factory (AppFactory.default())
  • Boot the application (app.boot())
  • Create an application instance instance (app.buildInstance())
  • Boot the application instance instance (instance.boot())
  • Invoke instance.visit

Everything in this list except the last item should actually be done within the sandboxed VM context instead. This will allow these steps to be further optimized and shared across visits (since the VM scripts we evaluate share bytecode and compilation information), and it will also significantly improve the prototype extension compatibility (#170).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants