Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly track deprecations #459

Open
1 task
MelSumner opened this issue Dec 4, 2018 · 4 comments
Open
1 task

Properly track deprecations #459

MelSumner opened this issue Dec 4, 2018 · 4 comments

Comments

@MelSumner
Copy link
Member

Issue

Deprecation items should have a link to the RFC that deprecates the item. This helps with transparency and also confirms that the deprecated item listed has relevant information.

To fix

  • Update the deprecated item title to contain the link to the RFC that specified the deprecation

Example

From https://www.emberjs.com/deprecations/v3.x
In the screenshot below, Getting the @each property and Use notifyPropertyChange instead of propertyWillChange and propertyDidChange should each be a link to the RFC that specifies that they should be deprecated.

image

@MelSumner
Copy link
Member Author

This should be done after ember-learn/ember-website#119

@stale
Copy link

stale bot commented Jul 8, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@mansona
Copy link
Member

mansona commented Jul 12, 2019

@MelSumner now that we decided against doing ember-learn/ember-website#119 do you have any objection to me moving this into the deprecations repo? using the "transfer issue" feature I mean :)

@stale
Copy link

stale bot commented Nov 9, 2019

This issue has been automatically marked stale. If this issue is something that still needs work, please add a comment and it will remain open, otherwise it will close in 7 days. You are welcome to open a new issue if you miss the window. Thanks!

@mansona mansona transferred this issue from ember-learn/ember-website Nov 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants