Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ember data will no longer generate docs in a production build #78

Closed
Gaurav0 opened this issue Nov 15, 2019 · 1 comment
Closed

ember data will no longer generate docs in a production build #78

Gaurav0 opened this issue Nov 15, 2019 · 1 comment

Comments

@Gaurav0
Copy link
Contributor

Gaurav0 commented Nov 15, 2019

Related: #74

After this change:
https://github.com/emberjs/data/blob/fbf06f8ba23cc3a41c931e344648e6042ad2b233/packages/-ember-data/yuidoc.json#L6

(which will go into Ember 3.16)

This line will no longer work in ember-jsonapi-docs:

await runCmd(project === 'ember' ? 'yarn docs' : 'yarn build:production', projDirPath)

We will have to do something different for versions of Ember Data before and after 3.16, because there will no longer be a single command that will generate docs in all versions of Ember Data..

cc @sivakumar-kailasam @runspired @efx

@sivakumar-kailasam
Copy link
Member

Fixed in b61a267 & this should be backward compatible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants