Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor how data is stored in Elasticsearch #276

Open
Syndesi opened this issue Mar 29, 2024 · 0 comments
Open

Refactor how data is stored in Elasticsearch #276

Syndesi opened this issue Mar 29, 2024 · 0 comments
Labels
Enhancement Improving existing functionalities.
Milestone

Comments

@Syndesi
Copy link
Member

Syndesi commented Mar 29, 2024

Currently the elements data is stored on the root level of Elasticsearch documents, which leads to possible property name conflicts, which in turn were solved by giving system properties priority.

However this has still two disadvantages:

  • If new system properties are introduced, it might delete data from Elasticsearch or make such original properties no longer accessible by Elasticsearch.
  • If overwriting such properties is not handled correctly, then user data might be interpreted as system data, which could lead to security vulnerabilities.

Therefore I propose the following concept:

  • System properties are stored in the root level of documents instead.
  • The element's data is stored within the system property data.

This would eliminate the aforementioned points completely, leave a whole namespace for future expansion, and make it more clearer to end users which properties are user defined and which are not.

@Syndesi Syndesi added this to the 0.2.0 milestone Mar 29, 2024
@Syndesi Syndesi added the Enhancement Improving existing functionalities. label May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improving existing functionalities.
Projects
Status: Todo
Development

No branches or pull requests

2 participants