Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storybook build fails with ember-destroyable-polyfill #96

Open
gossi opened this issue Aug 23, 2020 · 2 comments
Open

Storybook build fails with ember-destroyable-polyfill #96

gossi opened this issue Aug 23, 2020 · 2 comments

Comments

@gossi
Copy link

gossi commented Aug 23, 2020

I've upgrade hokulea to latest dependencies PR: hokulea/hokulea#13

With that I've upgrade to @glimmer/component and @glimmer/tracking to v1.0.1 and ember to v3.20 and not sure which one of those upgrades brings in ember-destroyable-polyfill. However, they break my storybook build on netlify. Here is the log: https://app.netlify.com/sites/hokulea/deploys/5f42add1bae43a0008544de5 (@hokulea/explorer is the addon which runs the storybook). The build runs locally for me, which keeps me wondering.

There is more to it, that might all depend together. Also the tests work for me locally but fail on github actions. Here is the latest run: https://github.com/hokulea/hokulea/pull/13/checks?check_run_id=1018844223

Which brings me to that fact, that I reported a similar problem to storybook: storybookjs/storybook#11853 I thought this issue is because storybook runs its own webpack bundling and as part of that fails to parse the template in there. Now I think, this is even more connected to ember itself.

I'm kind stuck with this but happy to provide help or am up for pairing

@rwjblue
Copy link
Member

rwjblue commented Sep 1, 2020

Hmm, neither @glimmer/component nor @glimmer/tracking use this polyfill themselves. My guess would be something like ember-modifier@2 (which does use this polyfill).

@rwjblue
Copy link
Member

rwjblue commented Sep 1, 2020

The failure in that PR's tests that I see:

Build Error (broccoli-persistent-filter:Babel > [Babel: @hokulea/buttons]) in @hokulea/buttons/components/accent-button/stories.ts
@hokulea/buttons: /home/runner/work/hokulea/hokulea/packages/buttons/@hokulea/buttons/components/accent-button/stories.ts: Can't reference '{"id":"f8hLISdf","block":"{\"symbols\":[],\"statements\":[[2,\"\\n      \"],[8,\"accent-button\",[[24,\"aria-label\",\"Go Tomster!\"]],[[],[]],[[\"default\"],[{\"statements\":[[2,\"\\n        \"],[10,\"span\"],[14,\"aria-hidden\",\"true\"],[12],[2,\"🐹\"],[13],[2,\"\\n      \"]],\"parameters\":[]}]]],[2,\"\\n    \"]],\"hasEval\":false,\"upvars\":[]}","meta":{}}' as a bare identifier (This is an error on an internal node. Probably an internal error.)

Is also seems unrelated to this polyfill 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants