Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usage as an Addon Dependency #24

Open
alexlafroscia opened this issue Aug 7, 2020 · 5 comments
Open

Usage as an Addon Dependency #24

alexlafroscia opened this issue Aug 7, 2020 · 5 comments

Comments

@alexlafroscia
Copy link

It seems that installing this package as a dependency of an addon does not make the polyfill available to the host application. Is this intentional?

@Ravenstine
Copy link

@alexlafroscia It works for me if I move it from "devDependencies" to "dependencies" in package.json.

@alexlafroscia
Copy link
Author

Interesting... I had it listed in dependencies but it didn't seem to work 🤔

@Ravenstine
Copy link

Huh, IDK. 🤷 I definitely have it working with ember-source 3.20.4. Maybe it's because I'm using it in an add-on.

@rwjblue
Copy link
Member

rwjblue commented Oct 16, 2020

Both the host application and the addon in question need to have the dependency (in dependencies for the addon, and either dependencies or devDependencies for the app).

@rwjblue
Copy link
Member

rwjblue commented Oct 16, 2020

If someone has the time, I'd love a PR adding both documentation for this as well as adding an assertion in the included hook when we know that things aren't setup correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants