Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up deprecations that were until 6.0 #20816

Open
4 tasks
kategengler opened this issue Dec 23, 2024 · 0 comments
Open
4 tasks

Clean up deprecations that were until 6.0 #20816

kategengler opened this issue Dec 23, 2024 · 0 comments

Comments

@kategengler
Copy link
Member

Clean up and remove code gated by deprecations that were until: 6.0.

  • DEPRECATE_IMPLICIT_ROUTE_MODEL
  • DEPRECATE_TEMPLATE_ACTION
  • DEPRECATE_COMPONENT_TEMPLATE_RESOLVING
  • DEPRECATE_ARRAY_PROTOTYPE_EXTENSIONS -- this one is atypical and requires more digging to figure out what needs to be removed and what tests need to be updated

For each deprecation, you'll find calls to deprecateUntil with the deprecation, for example:

deprecateUntil(`Usage of the \`{{action}}\` modifier is deprecated. Migrate to native functions and function invocation.`,
DEPRECATIONS.DEPRECATE_TEMPLATE_ACTION);

These calls and everything in that code path should be removed. As of 6.0, these calls with until: 6.0 behave as throws so none of the code in that path is in use.

There are also calls to testUnless with the deprecations, like so:

`${testUnless(DEPRECATIONS.DEPRECATE_TEMPLATE_ACTION.isRemoved

These tests can be removed.

Finally, the deprecations themselves should be removed from deprecations/index.ts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant