From e916a518c65a44aec79ae4ec97e15d75e19a7db1 Mon Sep 17 00:00:00 2001 From: Edward Faulkner Date: Sat, 7 Sep 2024 17:22:11 -0400 Subject: [PATCH] fixing up entirely-skipped tests --- tests/scenarios/engines-test.ts | 6 +----- tests/scenarios/fastboot-app-test.ts | 3 +-- tests/scenarios/watch-mode-test.ts | 15 ++++++--------- 3 files changed, 8 insertions(+), 16 deletions(-) diff --git a/tests/scenarios/engines-test.ts b/tests/scenarios/engines-test.ts index 7d94e373c..2353576fc 100644 --- a/tests/scenarios/engines-test.ts +++ b/tests/scenarios/engines-test.ts @@ -81,11 +81,7 @@ let engineScenarios = appScenarios.map('engines', project => { }); engineScenarios - .skip('lts_3_28-engines') // this skip should be removed before https://github.com/embroider-build/embroider/pull/1435 is merged - .skip('lts_4_4-engines') // this skip should be removed before https://github.com/embroider-build/embroider/pull/1435 is merged - .skip('release-engines') // this skip should be removed before https://github.com/embroider-build/embroider/pull/1435 is merged - .skip('lts_5_8-engines') // this shouldn't be run - .skip('canary-engines') // this shouldn't be run + .skip() .map('without-fastboot', () => {}) .forEachScenario(scenario => { Qmodule(scenario.name, function (hooks) { diff --git a/tests/scenarios/fastboot-app-test.ts b/tests/scenarios/fastboot-app-test.ts index 0cd0c444f..f55906437 100644 --- a/tests/scenarios/fastboot-app-test.ts +++ b/tests/scenarios/fastboot-app-test.ts @@ -83,8 +83,7 @@ appScenarios merge(project.files, loadFromFixtureData('fastboot-app')); }) // TODO remove once https://github.com/ember-fastboot/ember-cli-fastboot/issues/925 is fixed - .skip('lts_5_8-fastboot-app-test') - .skip('canary-fastboot-app-test') + .skip() .forEachScenario(scenario => { Qmodule(scenario.name, function (hooks) { let app: PreparedApp; diff --git a/tests/scenarios/watch-mode-test.ts b/tests/scenarios/watch-mode-test.ts index 50f8c4d29..4aa29f6cb 100644 --- a/tests/scenarios/watch-mode-test.ts +++ b/tests/scenarios/watch-mode-test.ts @@ -9,15 +9,12 @@ import CommandWatcher, { DEFAULT_TIMEOUT } from './helpers/command-watcher'; const { module: Qmodule, test } = QUnit; -let app = appScenarios - .skip('canary') - .skip('lts_5_8') - .map('watch-mode', () => { - /** - * We will create files as a part of the watch-mode tests, - * because creating files should cause appropriate watch/update behavior - */ - }); +let app = appScenarios.skip().map('watch-mode', () => { + /** + * We will create files as a part of the watch-mode tests, + * because creating files should cause appropriate watch/update behavior + */ +}); class File { constructor(readonly label: string, readonly fullPath: string) {}