-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor GP Surrogates #235
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi @AVHopp, @Scienfitz: I'd say the PR is 95% ready but currently still waiting on the final fixes in #221. But if you like, you can already have a sneak peek and provide some feedback upfront 🙃 |
AdrianSosic
commented
May 7, 2024
AdrianSosic
force-pushed
the
refactor/gaussian_process
branch
from
May 13, 2024 08:40
d6631de
to
ff19f49
Compare
AdrianSosic
force-pushed
the
refactor/gaussian_process
branch
2 times, most recently
from
May 13, 2024 11:16
25cdbfa
to
48b7cfc
Compare
AdrianSosic
commented
May 13, 2024
AdrianSosic
force-pushed
the
refactor/gaussian_process
branch
5 times, most recently
from
May 14, 2024 13:52
4653092
to
3930ef6
Compare
AVHopp
reviewed
May 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First round of comments. Have not looked at everything in detail yet.
AdrianSosic
force-pushed
the
refactor/gaussian_process
branch
from
May 15, 2024 06:47
3930ef6
to
178371b
Compare
Scienfitz
reviewed
May 15, 2024
AdrianSosic
force-pushed
the
refactor/gaussian_process
branch
from
May 16, 2024 08:36
178371b
to
1d856a7
Compare
Scienfitz
reviewed
May 16, 2024
AdrianSosic
force-pushed
the
refactor/gaussian_process
branch
from
May 16, 2024 09:28
aaed381
to
b812f6c
Compare
Scienfitz
approved these changes
May 16, 2024
AVHopp
approved these changes
May 16, 2024
AdrianSosic
force-pushed
the
refactor/gaussian_process
branch
from
May 16, 2024 12:18
b812f6c
to
95b0f50
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the GP surrogates into their own subpackage, thereby significantly enhancing configurability:
KernelFactory
protocol that is now used by the surrogate and enables flexible context-specific construction of kernels.Not included, needs to be done next:
LikelihoodFactory
andMeanFactory
mechanisms to give flexible control of the likelihood and mean models