Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only one send newsletter implementation. #60

Open
danielsokolowski opened this issue Mar 23, 2012 · 0 comments
Open

Only one send newsletter implementation. #60

danielsokolowski opened this issue Mar 23, 2012 · 0 comments

Comments

@danielsokolowski
Copy link

Hi All,

We now have send_newsletter_continuous and send_newsletter in the core, I think this is confusing and complicates code maintainability. What are your thoughts on picking one implementation and making it the default send_newsletter.

  1. send_newsletter - is the original which with a few bug fixes and tweaks works relatively well and uses predictable cron.
  2. send_newsletter_continuous - is a new merged implementation as per https://github.com/Fantomas42/emencia-django-newsletter/pull/53#issuecomment-4193230 and from my limited understanding of it it uses threads, is not cron friendly, is persistent --- I have no experience using it however.

Bottom line I am arguing we ought to have just one manage.py command regardless of which approach is used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant