Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from numeric primitive times to Instant/Duration #49

Open
emichael opened this issue May 12, 2023 · 7 comments
Open

Migrate from numeric primitive times to Instant/Duration #49

emichael opened this issue May 12, 2023 · 7 comments
Labels
enhancement New feature or request first issue Good for someone getting started contributing to dslabs

Comments

@emichael
Copy link
Owner

We should be using Instant and Duration from the java.time package instead of millisecond times stored as longs or ints.

@emichael emichael added enhancement New feature or request first issue Good for someone getting started contributing to dslabs labels May 12, 2023
@ChrisPerezLebron
Copy link

Hi, I am new to open source and would love to help out. Could you provide me with more information regarding where in the codebase these changes need to be made?

@AsfarHorani
Copy link

AsfarHorani commented May 12, 2023

@emichael any further information? i am done with cloning the repo which classes do I have to work on?
image

@AsfarHorani
Copy link

@emichael Please assign it to me

@AsfarHorani
Copy link

/assign

@emichael
Copy link
Owner Author

Hi, Asfar and Chris. Thanks so much for the offer to help! This is really something I want someone who's already done the labs and is familiar with the codebase to tackle, though.

@AsfarHorani
Copy link

Ahh that's really sad. I saw the good first issue tag and i wanted to contribute. If u get some time u can explain me code base for a while.

@AsfarHorani
Copy link

@emichael if there's any other issue i can work on please let me know thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request first issue Good for someone getting started contributing to dslabs
Projects
None yet
Development

No branches or pull requests

3 participants