Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use failAndContinue liberally throughout tests #57

Open
emichael opened this issue Jul 12, 2023 · 0 comments
Open

Use failAndContinue liberally throughout tests #57

emichael opened this issue Jul 12, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@emichael
Copy link
Owner

Most of the tests (with the exception of search tests with searches for goal states) exit when they fail. It would be better if we ran tests through to completion by reporting failures with the failAndContinue method that was recently added. (Of course, some tests must fail because a precondition for continuing wasn't met.)

Additional requirements:

  • Cleanup BaseJUnitTest#failedSearchTest. It's no longer needed if failAndContinue exists.
  • Failures should be printed as they happen so that the errors are in their proper context. They shouldn't be printed twice though. This might have to be done with a static IdentityHashSet that tracks which exceptions have been printed. This isn't the current behavior of failAndContinue.
  • Users should be able to disable this behavior and get all tests to fail fast with a flag to run_tests.py.
@emichael emichael added the enhancement New feature or request label Jul 12, 2023
@emichael emichael changed the title Use failAndContinue liberally through tests Use failAndContinue liberally throughout tests Jul 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant