Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fn add_boxed(&mut self, Box<dyn PlotItem>) method to PlotUi. #53

Open
freeformstu opened this issue Oct 6, 2024 · 0 comments · May be fixed by #51
Open

Add fn add_boxed(&mut self, Box<dyn PlotItem>) method to PlotUi. #53

freeformstu opened this issue Oct 6, 2024 · 0 comments · May be fixed by #51

Comments

@freeformstu
Copy link

Is your feature request related to a problem? Please describe.

We have a somewhat unique setup in which we use dioxus for state management and egui for all of the underlying component rendering. When passing attributes through dioxus we have to cast the incoming type which requires that the trait objects be "object safe". PlotItem is not object safe, so we can't pass it through directly. But we also cannot pass in our own trait which has a method such as fn as_egui_plot_item(&self) -> impl PlotItem because that is also not object safe so instead we have a trait which has a method fn as_egui_plot_item(&self) -> Box<dyn PlotItem>. This cannot be passed to the existing fn add(&self, impl PlotItem) method because Box<dyn PlotItem> does not satisfy the impl PlotItem argument.

Describe the solution you'd like

Add an fn add_boxed(&mut self, Box<dyn PlotItem>) method to allow insertion directly into the underlying plot_items Vec.

Describe alternatives you've considered

  1. Make PlotItem object safe (likely a pretty large effort and I'm not sure anyone else cares about this).
  2. impl<T: PlotItem> PlotItem for Rc<T> so we can pass an Rc directly to the .add( function. (This could also be done for Arc and others for convenience).
  3. Possibly some more options?

Additional context

@freeformstu freeformstu linked a pull request Oct 6, 2024 that will close this issue
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant