Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Following the README instructions results in an invalid build #65

Open
adamsoderstrom opened this issue Jun 27, 2023 · 3 comments
Open

Comments

@adamsoderstrom
Copy link

adamsoderstrom commented Jun 27, 2023

Description

Following the README's guidance:

Installation

  1. yarn
  2. yarn run start
  3. Server now up on http://localhost:3000

...Results in the following error:

ERROR in ./src/client/hooks/useCircuitContext/useCircuitContext.ts 1:0-49
Module not found: Error: Can't resolve 'alma-webgl' in '/Users/adamsoderstrom/Documents/adamsoderstrom/www/projects/alma/packages/alma-web/src/client/hooks/useCircuitContext'
 @ ./src/client/routes/CircuitRoute/CircuitRoute.tsx 12:0-84 46:38-55
 @ ./src/client/containers/App/App.tsx 7:0-70 20:95-107
 @ ./src/client/index.tsx 3:0-43 4:36-39
...

This seems to only occur when there's no initial build directory in the alma-webgl directory.

Steps to reproduce

  1. git clone this repo. (ensure that there's no build's in packages/*).
  2. yarn && yarn start
@adamsoderstrom
Copy link
Author

Some troubleshooting

When looking through the logs upon executing yarn start, lerna seems to output the packages in the following order:

 >  Lerna (powered by Nx)   Running target build for 4 projects:

    - alma-glsl
    - alma-graph
    - alma-web
    - alma-webgl

   With additional flags:
     --watch=true

Assuming that this is the sequential order that lerna builds the packages in, then i think it makes some sense that the alma-web package results in an error, related to the absence of alma-webgl. While running the yarn start script and examining the packages/alma-webgl directory, there's no build directory created (which it is in the other packages).

@adamsoderstrom
Copy link
Author

Altering the yarn build:dev script as follows:

 "build:dev": "npx lerna run build --no-sort -- --watch",

...Makes the alma-web package initially fail and then resolve the error. I guess this isn't sufficient, since it doesn't fix the issue when running yarn build.

@emilwidlund
Copy link
Owner

Thanks @adamsoderstrom. Appreciate it! I'm going to look at it.

I have some big Alma-announcements coming soon also :)

@polar-sh polar-sh bot added polar and removed polar labels Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants