Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XMLNode is an unidiomatic type name #26

Open
jplatte opened this issue Jan 6, 2021 · 3 comments
Open

XMLNode is an unidiomatic type name #26

jplatte opened this issue Jan 6, 2021 · 3 comments

Comments

@jplatte
Copy link

jplatte commented Jan 6, 2021

It should be called XmlNode, the same way many libraries¹ have a Json type (not JSON), xml has UriMapping instead of URIMapping and so on.

¹ sqlx, actix-web, rocket, ...

@ctrlcctrlv
Copy link
Contributor

MFEK says there's not one right way to name Rust things.

Json, Uri are ugly, imo…this crate is fine…changing it now would break many downstream users for no benefit.

@jplatte
Copy link
Author

jplatte commented Jan 25, 2022

It's part of the official API guidelines that acronyms in type names should not be all-uppercase: https://rust-lang.github.io/api-guidelines/naming.html

MFEK is just as wrong as xmltree.

@ctrlcctrlv
Copy link
Contributor

cool opinions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants