Squid preparations #370
Merged
Squid preparations #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix DCE to not eliminate implicit ValDefs - Fix Reduce.inlineTrivialValDefs to not treat implicit ValDefs as trivial - Fix the ordering of implicit ValDefs in FoldForestFusion
|
The Travis issue seems to be some irrelevant config issue on Travis. All tests run fine locally (even with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR doesn't have any actual Squid stuff, but just contains some of the changes that I did while trying to integrate Squid. I couldn't complete the Squid integration (#369), but I made some changes that could go into the master nevertheless.
The 1st commit just fixes some minor typos and such.
The 2nd and 3rd commits would have been necessary if we wanted to move
addContextto the beginning of our pipelines. In the meantime, I realized that this is probably not needed even for the Squid integration. But they are still good to have, as they fix some bugs with implicit ValDefs that might pop up in other circumstances as well.The 4th commit is needed for a transformation that we would need to do before we pass a tree to Squid. (see the first issue in #369) I think it is still good to have this in the master, since sooner or later we would try to integrate Squid again, and it is good if the master branch is not too far from https://github.com/ggevay/emma-1/tree/squid , where I tried to do the integration.