Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Igir hangs when handling zip files that have an "archive comment" #1400

Open
conchyliculture opened this issue Dec 24, 2024 · 0 comments
Open
Labels
potential-bug A potential issue that needs confirmation and/or triage

Comments

@conchyliculture
Copy link

Paste the command

./igir -v copy zip test --dat /tmp/dats/No-Intro/* --input /tmp/roms/ --output /tmp/roms2 --dir-dat-name

Describe the bug

Scanning for DATs passes, but while the tool is scanning roms, it will hang on the zip files that have a "archive comment", aslo called "File comment", that can be added to the end of the zip central directory when creating a zip (for example with --archive-comment if uzing zip from Info-zip

Unzipping these archives, and re-zipping then without the comment fixes the issue

Expected behavior

No hanging

Debug logs

DAT(s) used

No response

igir version

v.3.0.1

Node.js version

N/A

Operating system

debian testing

Additional context

This is also what might be causing #1399

@conchyliculture conchyliculture added the potential-bug A potential issue that needs confirmation and/or triage label Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
potential-bug A potential issue that needs confirmation and/or triage
Projects
None yet
Development

No branches or pull requests

1 participant