Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors found in manage_python_project.ipynb notebook #167

Closed
yakutovicha opened this issue Dec 11, 2023 · 10 comments · Fixed by #189
Closed

Errors found in manage_python_project.ipynb notebook #167

yakutovicha opened this issue Dec 11, 2023 · 10 comments · Fixed by #189

Comments

@yakutovicha
Copy link
Member

Please report here any errors or suggestions for the manage_python_project.ipynb.

@edoardob90 edoardob90 pinned this issue Dec 11, 2023
@despadam
Copy link
Contributor

Typo in Preparatory exercise:

  • other yours or the one you have forked --> should be 'either'

@fabioacl
Copy link
Contributor

In the line bumpver update --minor --dry-run it should be --dry and not --dry-run

@fabioacl
Copy link
Contributor

fabioacl commented Dec 11, 2023

In the Testing section, add jobs: before tests.

@edoardob90
Copy link
Member

In the "Pre commit" section: perhaps specify that the pre-commit run --all-files requires a config file to be present.

@anates
Copy link

anates commented Dec 11, 2023

Executing bumpver update --minor --dry-run as proposed fails, as there is no entry for __version__ in __init__.py in mypackage. Manually adding this entry resolves the issue.

@anates
Copy link

anates commented Dec 11, 2023

Last entry in the notebook for publishing a new release, currently reading

- uses: softprops/[email protected]
   name: Create release

should be

    - name: Create release
      uses: softprops/[email protected]  

afaik. Is that correct?

@edoardob90
Copy link
Member

There seems to be an issue on Windows and the yamlfmt hook. I don't know if it's reproducible every time, but it seems to be a bug in the hook script itself. Check out: jumanjihouse/pre-commit-hook-yamlfmt#25

@yakutovicha
Copy link
Member Author

The exercise on releasing automation needs to be revised. It is not clear to people what is test.pypi.og and how to release things there. Maybe, it is enough to release only on GitHub.

@yakutovicha yakutovicha unpinned this issue Dec 12, 2023
@yakutovicha
Copy link
Member Author

Last entry in the notebook for publishing a new release, currently reading

- uses: softprops/[email protected]
   name: Create release

should be

    - name: Create release
      uses: softprops/[email protected]  

afaik. Is that correct?

It should not matter, as after reading it becomes a dictionary:

{
    "name": "Create release",
    "uses": "softprops/[email protected]",
}

but I agree this way is more consistent. I will fix it.

@yakutovicha
Copy link
Member Author

yakutovicha commented Dec 14, 2023

Executing bumpver update --minor --dry-run as proposed fails, as there is no entry for __version__ in __init__.py in mypackage. Manually adding this entry resolves the issue.

This did directly in the corresponding repo empa-scientific-it/mypackage@4393c23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants