Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors found in library_numpy notebok #181

Open
yakutovicha opened this issue Dec 14, 2023 · 6 comments
Open

Errors found in library_numpy notebok #181

yakutovicha opened this issue Dec 14, 2023 · 6 comments
Labels
advanced tutorial bug Something isn't working

Comments

@yakutovicha
Copy link
Member

No description provided.

@yakutovicha yakutovicha pinned this issue Dec 14, 2023
@GCatarina
Copy link

Typo:

Exercises on specifying the data type.

  1. Create an array of 100 booleans all set to True. The array should have dimensions 2x3.

The part "The array should have dimensions 2x3." should be removed

@fabioacl
Copy link
Contributor

In Indexing, slicing, and iterating, the first sentence after the first python code starts with Unlinke.

@yakutovicha
Copy link
Member Author

In the final exercises, when integrating the function we need to be explicit about the density of x points. Because different point density gives slightly different results. "Slightly different" means sufficient enough to cause the test failure.

@baffelli
Copy link
Member

For the exercise on eigenvalues:

  • The solution uses eigh. If people use eig the test will fail because the order of eigenvalues is different. This can be overcome by testing for invariants like the trace and the determinant.
  • The exercise should ideally be parametrized in order for multiple matrices to be teasd

@GCatarina
Copy link

In Exercises on NumPy routines, exercise 2., tests fail if we do not use the fact that the matrix is hermitian: eig and eigh give same eigenvalues but in different orders, and eigenvectors are slightly different

@baffelli
Copy link
Member

In Exercises on NumPy routines, exercise 2., tests fail if we do not use the fact that the matrix is hermitian: eig and eigh give same eigenvalues but in different orders, and eigenvectors are slightly different

Thanks, we already noted this above

@edoardob90 edoardob90 unpinned this issue Dec 15, 2023
@edoardob90 edoardob90 added the bug Something isn't working label Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
advanced tutorial bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants