Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors found in basic_datatypes #267

Open
7 tasks
despadam opened this issue Nov 27, 2024 · 3 comments
Open
7 tasks

Errors found in basic_datatypes #267

despadam opened this issue Nov 27, 2024 · 3 comments

Comments

@despadam
Copy link
Contributor

despadam commented Nov 27, 2024

  • We start printing examples directly with string interpolation, never show them the simple print(a)
  • Start with explaining the difference between print and return (probably in the intro). They get confused by the solution function syntax.
  • math was not imported for solution_quadratic_equation
  • Make the description more clear for exercises lists_are_equal and lists_are_not_same_but_equal
  • Move each exercise description above the expected exercise solution, otherwise you have to scroll a lot after printing the test outputs.
  • Exercise remove every second element from list does not have a clear description. Should we use 'return' or 'extract' instead of 'remove'?
  • In the speed comparison between set, list, tuple can we hide the code and only print the result of the comparison?
@edoardob90 edoardob90 changed the title Nov24-Intro-Tutorial: Errors found in basic_datatypes Errors found in basic_datatypes Nov 27, 2024
@edoardob90
Copy link
Member

edoardob90 commented Nov 27, 2024

Exercise 1 of dictionaries: "Write a program that receives a dictionary and a key as input and returns the value of the key if it is in the dictionary, None otherwise. The dictionary should remain unchanged."

We should make it clear that the key to return is key, the input variable.

@Snowwpanda
Copy link
Collaborator

  • True and False are like 1 and 0 in a set, and there is some wierd behavior if we put 1 and True into a set, one of the examples in sets does this and should probably be taken out.

@edoardob90
Copy link
Member

edoardob90 commented Nov 28, 2024

Definition of string.strip(). We have

returns a copy of the string with any leading or trailing characters whitespaces removed

Should be

return a copy of the string with the leading and trailing whitespace characters removed. You can pass a string argument, and all the combinations of its values are removed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants