Streaming #72
Merged
Streaming #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kinplemelon
force-pushed
the
kinple/dev
branch
from
40446f1 to
14206d6
Compare
ysfscream
approved these changes
Nov 29, 2024
I think we do not need to deliver all things in one package. Component's hooks only work for their related components? 🤔 |
0721Betty
reviewed
Nov 29, 2024
Comment on lines
+44
to
+47
| "element-plus": "^2.3.0", | ||
| "rollup-plugin-visualizer": "^5.12.0", | ||
| "vue": "^3.2.0", | ||
| "vue-tsc": "^2.1.10" |
There was a problem hiding this comment.
Why not use the latest package?
There was a problem hiding this comment.
Since dashboard is still using version 3.2 of vue.. it's ok that the vue used by cloud satisfies this version number.
No, it might be used elsewhere, so I put it in the |
0721Betty
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure the current structure is reasonable, I didn't divide the packages in so much detail (e.g. hooks, enums and then put them in a separate package), so if you have any suggestions or comments, please say so!