Address review comments

Author: RReverser

src/lib/libstrings.js

@@ -44,6 +44,7 @@ addToLibrary({
     return UTF8Decoder.decode(heapOrArray.buffer ? {{{ getUnsharedTextDecoderView('heapOrArray', 'idx', 'endPtr') }}} : new Uint8Array(heapOrArray.slice(idx, endPtr)));
 #else // TEXTDECODER == 2
 #if TEXTDECODER
+    // When using conditional TextDecoder, skip it for short strings as the overhead of the native call is not worth it.
     if (endPtr - idx > 16 && heapOrArray.buffer && UTF8Decoder) {
       return UTF8Decoder.decode({{{ getUnsharedTextDecoderView('heapOrArray', 'idx', 'endPtr') }}});
     }

test/test_core.py

@@ -335,7 +335,7 @@ def decorated(self, *args, **kwargs):
   return outer_decorator
 
 
-def maybe_with_textdecoder(f):
+def with_both_text_decoder(f):
   assert callable(f)
 
   @wraps(f)
@@ -5662,39 +5662,39 @@ def test_utime(self):
   def test_futimens(self):
     self.do_runf('utime/test_futimens.c', 'success')
 
-  @maybe_with_textdecoder
+  @with_both_text_decoder
   def test_utf(self):
     self.set_setting('EXPORTED_RUNTIME_METHODS', ['getValue', 'setValue', 'UTF8ToString', 'stringToUTF8OnStack'])
     self.do_core_test('test_utf.c')
 
-  @maybe_with_textdecoder
+  @with_both_text_decoder
   def test_utf32(self):
     self.do_runf('utf32.cpp', 'OK (long).\n')
 
-  @maybe_with_textdecoder
+  @with_both_text_decoder
   @no_sanitize('requires libc to be built with -fshort-char')
   def test_utf32_short_wchar(self):
     if '-flto' in self.emcc_args or '-flto=thin' in self.emcc_args:
       self.skipTest('-fshort-wchar is not compatible with LTO (libraries would need rebuilting)')
     self.do_runf('utf32.cpp', 'OK (short).\n', emcc_args=['-fshort-wchar'])
 
-  @maybe_with_textdecoder
+  @with_both_text_decoder
   @crossplatform
   def test_utf16(self):
     self.do_runf('core/test_utf16.cpp', 'OK.')
 
-  @maybe_with_textdecoder
+  @with_both_text_decoder
   def test_utf8(self):
     self.do_runf('core/test_utf8.c', 'OK.')
 
-  @maybe_with_textdecoder
+  @with_both_text_decoder
   @also_with_wasm_bigint
   def test_utf8_bench(self):
     self.emcc_args += ['--embed-file', test_file('utf8_corpus.txt') + '@/utf8_corpus.txt']
     self.do_runf('benchmark/benchmark_utf8.c', 'OK.')
 
   # Test that invalid character in UTF8 does not cause decoding to crash.
-  @maybe_with_textdecoder
+  @with_both_text_decoder
   @also_with_minimal_runtime
   def test_utf8_invalid(self):
     self.do_runf('test_utf8_invalid.c', 'OK.')