Use ArrayBuffer.isView over instanceof ArrayBuffer. NFC

Its more compact and more accurate (since it works across iframes).

Author: sbc100

src/lib/libembind.js

@@ -452,7 +452,7 @@ var LibraryEmbind = {
         return str;
       },
       toWireType(destructors, value) {
-        if (value instanceof ArrayBuffer) {
+        if (!ArrayBuffer.isView(value)) {
           value = new Uint8Array(value);
         }
 

src/lib/libmemfs.js

@@ -259,7 +259,7 @@ addToLibrary({
       write(stream, buffer, offset, length, position, canOwn) {
 #if ASSERTIONS
         // The data buffer should be a typed array view
-        assert(!(buffer instanceof ArrayBuffer));
+        assert(ArrayBuffer.isView(buffer));
 #endif
 #if ALLOW_MEMORY_GROWTH
         // If the buffer is located in main memory (HEAP), and if

src/parseTools.mjs

@@ -1051,7 +1051,7 @@ function getUnsharedTextDecoderView(heap, start, end) {
   // a SAB, or can use .subarray() otherwise.  Note: We compare with
   // `ArrayBuffer` here to avoid referencing `SharedArrayBuffer` which could be
   // undefined.
-  return `${heap}.buffer instanceof ArrayBuffer ? ${unshared} : ${shared}`;
+  return `ArrayBuffer.isView(${heap}) ? ${unshared} : ${shared}`;
 }
 
 function getEntryFunction() {

test/codesize/test_minimal_runtime_code_size_hello_embind.json

@@ -1,10 +1,10 @@
 {
   "a.html": 552,
   "a.html.gz": 373,
-  "a.js": 7255,
-  "a.js.gz": 3314,
+  "a.js": 7252,
+  "a.js.gz": 3309,
   "a.wasm": 7315,
   "a.wasm.gz": 3371,
-  "total": 15122,
-  "total_gz": 7058
+  "total": 15119,
+  "total_gz": 7053
 }

test/codesize/test_minimal_runtime_code_size_hello_embind_val.json

@@ -1,10 +1,10 @@
 {
   "a.html": 552,
   "a.html.gz": 373,
-  "a.js": 5353,
-  "a.js.gz": 2522,
+  "a.js": 5350,
+  "a.js.gz": 2517,
   "a.wasm": 5953,
   "a.wasm.gz": 2796,
-  "total": 11858,
-  "total_gz": 5691
+  "total": 11855,
+  "total_gz": 5686
 }