Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some kind of install script to aid downstream packaging of emscripten #10169

Closed
sbc100 opened this issue Jan 9, 2020 · 6 comments
Closed

Comments

@sbc100
Copy link
Collaborator

sbc100 commented Jan 9, 2020

Today packaging emscripten is kind of pain and not well supported. For example its not clear which files should be included in the package. See:
#10093

This should be done in cooperation with downstream package maintainers (or at least one so we know it works).

Current packages of emscripten can be found here: https://repology.org/project/emscripten/versions

@yurivict
Copy link

You should implement the following items:

  1. configuration step: configure command should check that all dependencies are installed.
  2. installation procedure: it should install all required files into $DESTDIR$PREFIX
  3. regression suit: there should be a command that runs some basic tests and makes sue they produce expected results.

Currently the FreeBSD port is broken because it has no binaryen dependency, and bonaryen also breaks with invalid compilation flags.

As another example, Arch linux port is broken for the same reason: https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=emscripten-git

Brokenness of ports is a result of you not providing configuration/installation/regression procedures.

@juj
Copy link
Collaborator

juj commented Jan 12, 2020

Open source rarely works by placing demands on other people's free time. As has been stated before, Emscripten core team maintains distribution/installation via emsdk and via direct clone from repository.

If you would like to take the mantle of developing and maintaining Emscripten distributions to Linux distros you care about, or producing documentation to others for how they should do that, that would be great. You seem to know where to start the research already!

@yurivict
Copy link

I don't put demands, I am making a suggestion.

@kripken
Copy link
Member

kripken commented Jan 13, 2020

I think there might have been a misunderstanding here. Just to clarify - thanks @yurivict for the suggestions. As @juj said, the main active devs here probably don't have time to look into it themselves, since we focus on emsdk packaging. But we'd be happy if someone did, and we'd like to help them. But it would require someone to take on the work.

@sbc100 sbc100 changed the title Add some kind install script to aid downstream packaging of emscripten Add some kind of install script to aid downstream packaging of emscripten Jan 13, 2020
@stale
Copy link

stale bot commented Jan 14, 2021

This issue has been automatically marked as stale because there has been no activity in the past year. It will be closed automatically if no further activity occurs in the next 30 days. Feel free to re-open at any time if this issue is still relevant.

@stale stale bot added the wontfix label Jan 14, 2021
@sbc100
Copy link
Collaborator Author

sbc100 commented Jan 14, 2021

This was fixed in #10761

@sbc100 sbc100 closed this as completed Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants