Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add version check for binaryen #10175

Closed
sbc100 opened this issue Jan 9, 2020 · 1 comment · Fixed by #10219
Closed

Add version check for binaryen #10175

sbc100 opened this issue Jan 9, 2020 · 1 comment · Fixed by #10219
Assignees
@sbc100

Comments

@sbc100
Copy link
Collaborator

sbc100 commented Jan 9, 2020

Using the wrong version of binaryen currently fails in strange ways.

See: #10148
@sbc100 sbc100 self-assigned this Jan 9, 2020
sbc100 added a commit to WebAssembly/binaryen that referenced this issue Jan 9, 2020
@sbc100
Verify --version output matches CHANGELOG
b911fcd 
This will help with emscripten that wants to be able to programaticaly
check the --version of binaryen tools.

See emscripten-core/emscripten#10175
@sbc100 sbc100 mentioned this issue Jan 9, 2020
Merged
sbc100 added a commit to WebAssembly/binaryen that referenced this issue Jan 9, 2020
@sbc100
Verify --version output matches CHANGELOG
35da989 
The new version string looks like this:

  wasm-opt version 90 (version_90-18-g77329439d)

The version reported here is the version from the CMakeLists.txt file
followed by the git version in brackets.  We verify that the main
version here matches the CHANGELOG to prevent people from changing
one without changeing the other.

This will help with emscripten that wants to be able to programaticaly
check the --version of binaryen tools.

See emscripten-core/emscripten#10175
sbc100 added a commit to WebAssembly/binaryen that referenced this issue Jan 10, 2020
@sbc100
Verify --version output matches CHANGELOG (#2580)
4953bcc 
The new version string looks like this:

  wasm-opt version 90 (version_90-18-g77329439d)

The version reported here is the version from the CMakeLists.txt file
followed by the git version in brackets.  We verify that the main
version here matches the CHANGELOG to prevent people from changing
one without changeing the other.

This will help with emscripten that wants to be able to programaticaly
check the --version of binaryen tools.

See emscripten-core/emscripten#10175
@sbc100 sbc100 mentioned this issue Jan 12, 2020
Closed
sbc100 added a commit that referenced this issue Jan 15, 2020
@sbc100
Add version check on binaryen installation
cc7087e 
Fixes: #10175
@sbc100 sbc100 mentioned this issue Jan 15, 2020
Merged
sbc100 added a commit that referenced this issue Jan 17, 2020
@sbc100
Add version check on binaryen installation (#10219)
4fdb305 
Fixes: #10175
@sbc100 sbc100 mentioned this issue Jan 22, 2020
Closed
@sbc100
Copy link
Collaborator Author

sbc100 commented Jan 22, 2020

More packing troubles: WebAssembly/binaryen#2606

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbc100 sbc100

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add version check on binaryen installation emscripten-core/emscripten
1 participant
@sbc100