Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update harfbuzz port #11668

Closed
ebraminio opened this issue Jul 17, 2020 · 4 comments
Closed

Update harfbuzz port #11668

ebraminio opened this issue Jul 17, 2020 · 4 comments

Comments

@ebraminio
Copy link
Contributor

ebraminio commented Jul 17, 2020

HarfBuzz is moving away from providing cmake port used in emscripten to provide harfbuzz, however, guess instead forcing the project to use the meson port (which would be fantastic if possible), emscripten can just use harfbuzz's native amalgam/unity one source support used also in uharfbuzz, src/harfbuzz.cc of harfbuzz repository, to get the library compiled in emscripten, guess just needs to pass a HAVE_PTHREAD and HAVE_FREETYPE to CC when compiling src/harfbuzz.cc (one can see what cmake already passes however), I will also try this when could setup emscripten's development environment.

tldr: emcc src/harfbuzz.cc -DHAVE_PTHREAD -DHAVE_FREETYPE -fno-exceptions -fno-rtti -fvisibility-inlines-hidden can be used instead all the things happened on the harfbuzz port here.

@kripken
Copy link
Member

kripken commented Jul 17, 2020

Interesting, thanks for the info!

PR would be great if you or someone else has time, adding labels.

@sbc100
Copy link
Collaborator

sbc100 commented Jul 17, 2020

I think we should support meson .. I think some people have been using it already. See #11066 for example

@stale
Copy link

stale bot commented Jul 20, 2021

This issue has been automatically marked as stale because there has been no activity in the past year. It will be closed automatically if no further activity occurs in the next 30 days. Feel free to re-open at any time if this issue is still relevant.

@stale stale bot added the wontfix label Jul 20, 2021
@sbc100
Copy link
Collaborator

sbc100 commented Jul 20, 2021

Fixed in #14497

@sbc100 sbc100 closed this as completed Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants