resolve #555; DJIwarning only if OSD defined #559
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nerdCopter
commented
May 8, 2021
nerdCopter
commented
- fix compile for FC's without OSD.
- solution for OSD dependency in the MSP module (compiling without OSD not possible) #555 as provided by @raemin .
* fixes for FC without OSD
mricho
reviewed
May 8, 2021
mricho
reviewed
May 8, 2021
| @@ -768,10 +768,12 @@ bool mspProcessOutCommand(uint8_t cmdMSP, sbuf_t *dst) { | |||
| case MSP_NAME: { | |||
| // Show warning for DJI OSD instead of pilot name | |||
| // works if osd warnings enabled, osd_warn_dji is on and usb is not connected | |||
| #ifdef USE_OSD | |||
There was a problem hiding this comment.
This should be okay, however, if the FC does not have an analog OSD chip, it still technically could perform DJI OSD functions. But DJI custom osd would not work without enabling USE_OSD. I feel like theres a small user base that would lose DJI OSD on these FCs
There was a problem hiding this comment.
interesting. i don't know how to resolve such.
mricho
requested changes
May 8, 2021
* fixes for FC without OSD
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.