[emulsify-ds/compound/issues/57] Dependency Improvements & Refactoring & Renaming #269
Conversation
| @@ -4,3 +4,105 @@ | |||
| * @file | |||
| * Functions to support theming. | |||
| */ | |||
|
|
|||
There was a problem hiding this comment.
This might make more sense to go in the Emulsify Twig module rather than in each theme. If it's going to be the recommended way to write libraries, I'd hate for someone to not know what this is, and delete it from their theme, and then ask us why their libraries don't work... If it's in the module (which is a Drupal dependency) they can't delete it, and keeps "required" code out of their custom codebase.
There was a problem hiding this comment.
To do that, we also need to change the code a little bit. (Need to get the active theme and dir)
emulsify-drupal/emulsify.theme
Line 14 in 79f34c5
Or we can just wait for this feature to become included in the core https://www.drupal.org/project/drupal/issues/3092496
We can propagate the idea of If you don't know and if all works good, DON'T touch anything! 😄
|
@emircanerkul Thank you for submitting this work. I did a light functional test on this and the functionality you are adding is great! I think this is likely the direction we would like to take emulsify as it allows components to work a bit more independently and removes a manual step we all need to do with Drupal. Creating a drupal library to attach somewhere. |
|
@callinmullaney thanks to you too. |
Dependency Improvements & Refactoring & Renaming
With this PR, All components work as individuals. To accomplish that some hooks are written and webpack configs have been changed. Drupal automatically explores all sub-libraries.
Libraries in the global file are moved to their own files.
Dist folder output: All files are individually exported
┆Issue is synchronized with this Clickup by Unito