Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graceful handling for HTTP/2 GoAway frames. #730

Closed
tomchristie opened this issue Jun 16, 2023 · 0 comments · Fixed by #733
Closed

Graceful handling for HTTP/2 GoAway frames. #730

tomchristie opened this issue Jun 16, 2023 · 0 comments · Fixed by #733
Labels
bug Something isn't working

Comments

@tomchristie
Copy link
Member

When working with an HTTP/2 connection, a GoAway frame can be used to gracefully close the connection.
Our handling for this hasn't been working correctly, see encode/httpx#2112 and PrefectHQ/prefect#7442.

This was largely resolved by @zanieb's work on #679, which ensured that we at least properly push the connection into a closable state.

However, there's still some improvement to make here. When an HTTP/2 connection is closed with GoAway we'll currently raise exceptions for any requests that are made against the connection before we've seen the frame. Really we ought to gracefully retry any requests that are beyond the last_stream_id.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant