-
|
Why can't we include https://github.com/alex-oleshkevich/starsessions in Starlette? Even the basic functionality in Starlette is missing so much. And while I can contribute a lot of the changes to make sessions as great as they can be, I just can't bring myself to contribute to the Starlette sessions when there exists a much better library out there. I also think Sessions should be much better documented, here and in FastAPI. JWTs are really overused and overrated, sessions should be a main feature and the goto authentication mechanism for most web apps. But I digress. Is there a reason why Starsessions isn't part of Starlette? |
Beta Was this translation helpful? Give feedback.
Replies: 1 comment 6 replies
-
|
Disclaimer: I have not used
I think there's a lot of things that could be added to Starlette, but the main goal of Starlette is to be a minimal and composable web toolkit, not a complete web framework with all of the batteries included. The fact that it's possible to write an external package like
This is the whole point: why do we need to add it to Starlette when there is an external package? If the functionality in Starlette satisfies some fraction of users' basic functionality needs, we are happy to point to an external package for more advanced use cases. I'll also add that we are happy to direct users to an external package when Starlette is lacking a feature or is too basic. We actually have a whole page in our docs dedicated to this: https://www.starlette.io/third-party-packages/ |
Beta Was this translation helpful? Give feedback.
-
|
Yup I see your point. But also, when the Starlette version of things is really below industry standards, it makes me question whether this should be in Starlette at all. A better solution that I see is not having Sessions be part of Starlette, but having the documentation in Starlette mention starsessions might be better. |
Beta Was this translation helpful? Give feedback.
-
|
I don't disagree with you |
Beta Was this translation helpful? Give feedback.
-
|
That's a good point. 👍 |
Beta Was this translation helpful? Give feedback.
-
|
I don't mean to offend just in case, I know this is open source, super grateful to everyone who contributed what they have :D |
Beta Was this translation helpful? Give feedback.
-
|
No one is offended. |
Beta Was this translation helpful? Give feedback.
Disclaimer: I have not used
starsessionsand this response should not be interpreted as a commentary on that package in any way, even if it is referred to by name.I think there's a lot of things that could be added to Starlette, but the main goal of Starlette is to be a minimal and composable web toolkit, not a complete web framework with all of the batteries included. The fact that it's possible to write an external package like
starsessionsand easily integrate it into Starlette is a testament to the composability Starlette offers. On the minimal side of things, keeping complexity and dependencies to a minimum is really impo…