Static files not being served with follow_symlink=True

[falkoschindler]

With FastAPI 0.115.7 being released yesterday, which comes with Starlette >=0.42.0, we noticed a regression when serving static files (see zauberzeug/nicegui#4255). I don't really have a reproduction other than that every NiceGUI app is broken using Starlette 0.42.0.

The problem seems to be caused by PR #2711, especially this line:

By moving the call to os.path.realpath into the else block, it isn't called if follow_symlink is true. But if I understand correctly, os.path.realpath converts a PosixPath into a string, which is important for the comparison with the result of os.path.commonpath. It used to compare two strings, but now there is a string and a PosixPath which, apparently, are never equal.

This looks like a pretty severe bug. Or am I missing something?

[Kludex]

I don't really have a reproduction other than that every NiceGUI app is broken using Starlette 0.42.0.

Can you create an MRE using NiceGUI? Please explain how to run it. I'm not familiar with the package.

This looks like a pretty severe bug.

If it's a bug, it will be fixed.

[Kludex]

Please review: #2851, and check if it solves your issue.

[hofrob]

I'm seeing the same issue and #2851 fixes it!

[falkoschindler]

Oh yes, #2851 works! 👍🏻

[Kludex]

Solved on 0.45.3.