Skip to content

Commit b7a6cc2

Browse files
committed
Resolve review comment
1 parent 57af460 commit b7a6cc2

File tree

1 file changed

+7
-4
lines changed

1 file changed

+7
-4
lines changed

objdiff-core/src/obj/mdebug.rs

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -101,17 +101,20 @@ pub(super) fn parse_line_info_mdebug(
101101
}
102102

103103
let local_index = pdr.isym as u32;
104-
let mut size = None;
104+
let mut end_address = None;
105105
for sym in &symbols[global_sym_index..sym_end] {
106106
if sym.st == ST_END && sym.index == local_index {
107-
size = Some(sym.value);
107+
end_address = Some(sym.value);
108108
break;
109109
}
110110
}
111-
let Some(size) = size else {
111+
let Some(end_address) = end_address else {
112112
continue;
113113
};
114-
if size == 0 {
114+
let Some(size) = end_address.checked_sub(start_symbol.value) else {
115+
continue;
116+
};
117+
if size == 0 || size % 4 != 0 {
115118
continue;
116119
}
117120
let word_count = (size / 4) as usize;

0 commit comments

Comments
 (0)