Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix read error on objects with no .text section #67

Merged
merged 4 commits into from
Jun 4, 2024

Conversation

AetiasHax
Copy link
Contributor

The DWARF parser errors on object files with no .text sections, which makes it impossible to open objects where the target doesn't contain code yet.

I fixed this for both DWARF 1.1 and 2+, but I don't have a DWARF 1.1 object to test with so I suggest doing so before merging.

@encounter
Copy link
Owner

Thanks for the fix. I reverted the DWARF 1 changes, since it will hit the outer while condition at last text section, so there's no need to change it.

@encounter encounter merged commit a5a6a39 into encounter:main Jun 4, 2024
10 checks passed
@AetiasHax AetiasHax deleted the no-text branch June 16, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants